🦋 Changeset detected

Latest commit: 895153f

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

So this makes it so astro add cloudflare assumes Cloudflare works projects instead of Cloudflare pages projects and workers projects also need the public/.assetsignore workaround mentioned here https://docs.astro.build/en/guides/integrations-guide/cloudflare/#routing-on-cloudflare-workers

Can we add this too?

CodSpeed Performance Report

Merging #14564 will not alter performance

_{Comparing feat/cloudflare-add-wrangler (895153f) with main (7b45c65)}

Summary

✅ 6 untouched

Shouldn't this be a minor?

I don't think it needs to be a minor but we could talk about it in 5.15 either way. No strong opinion on this!

I don't think it needs to be a minor but we could talk about it in 5.15 either way. No strong opinion on this!

The title of the PR is definitely misleading then

@florian-lefebvre If this changes the behaviour of astro add cloudflare, are there any changes needed to the docs page for the cloudflare integration? Have you checked to see that we don't e.g. say "create these files..." that are now created?

2 things:

1. Maybe we should update the "manual install" section?
2. The .assetsignore file is covered in https://docs.astro.build/en/guides/integrations-guide/cloudflare/#routing-on-cloudflare-workers (I think it's fine there), wrangler.jsonc is mentionned in a few places

Regarding docs I think now we have https://docs.astro.build/en/guides/deploy/cloudflare/#cloudflare-workers and https://docs.astro.build/en/guides/deploy/cloudflare/#cloudflare-pages which will sort of need to be inverted

and https://docs.astro.build/en/guides/integrations-guide/cloudflare/#preview-with-wrangler can change to wrangler dev whereas now it is actually not the correct command it should be wrangler dev --assets=./dist but we don't need to specify the ./dist if users have a wrangler.jsonc

https://docs.astro.build/en/guides/integrations-guide/cloudflare/#sessions has mention to wrangler.json but should be wrangler.jsonc if we create this for users, as well as all mentions of wrangler.json on https://docs.astro.build/en/guides/integrations-guide/cloudflare/

@OliverSpeir @florian-lefebvre Are one of you able to make a docs PR with the suggested/necessary changes? I am not really familiar with Cloudflare, but can certainly grok proposed changes in a PR!

I am not very familiar with it either unfortunately, so @OliverSpeir if you don't mind I think it'd be better if you took this! At least as a first step.

EDIT: I'll open a PR to at least have something to get started

Will note, maybe we can nerd snipe @Adammatthiesen here, too! Calling in all Cloudflare reinforcements!

See withastro/docs#12603